search

ARCH-commons / arch-ontology

ARCH i2b2 PCORnet Ontology
Other
14 stars 13 forks source link

dbo.stringpart function doesn't use @delimiter arg #31

Closed ConnieZ closed 8 years ago

ConnieZ commented 8 years ago

This is a minor issue, I suppose. But the dbo.stringpart function in ontology_utils_mssql.sql script doesn't make use of @delimiter argument. It seems, instead of the '\' it should say @delimeter in the following lines: WHILE @num!=@el and CHARINDEX('\', @stringToSplit) > 0 SELECT @pos = CHARINDEX('\', @stringToSplit) Please reject this issue, if this is an incorrect assumption. Thanks.

jklann commented 8 years ago

Ah ha! You are correct!

matthewjoss commented 8 years ago

Fixed in the mssql utility script. Not fixed in oracle yet.