ARCH-commons / arch-ontology

ARCH i2b2 PCORnet Ontology
Other
14 stars 13 forks source link

c_dimcode needs a fix for several more pcornet_agetree.txt rows #39

Closed ConnieZ closed 8 years ago

ConnieZ commented 8 years ago

@jklann , per our dicussion Monday, I checked and HIPAA requires obscuring age if greater than 89, so my original comment was wrong. However, while I was checking for that, I noticed some more bad c_dimcodes in pcornet_agetree.txt for v2.1.1 of ontology. (https://github.com/SCILHS/scilhs-ontology/tree/master/Ontology/ForUpgradingOnly/pcornet_agetree.txt)

1) Date query in c_dimcode reversed. C_FULLNAME|C_OPERATOR|C_DIMCODE \PCORI\ENCOUNTER\Age at visit>= 65 years old\80| BETWEEN|((select birth_date from PCORI_Dev.dbo.patient_dimension where patient_num = PCORI_Dev.dbo.visit_dimension.patient_num) + (365.25 * 81)-1) AND ((select birth_date from PCORI_Dev.dbo.patient_dimension where patient_num = PCORI_Dev.dbo.visit_dimension.patient_num) + (365.25 * 80)-1)

\PCORI\ENCOUNTER\Age at visit>= 65 years old\81| BETWEEN|((select birth_date from PCORI_Dev.dbo.patient_dimension where patient_num = PCORI_Dev.dbo.visit_dimension.patient_num) + (365.25 * 82)-1) AND ((select birth_date from PCORI_Dev.dbo.patient_dimension where patient_num = PCORI_Dev.dbo.visit_dimension.patient_num) + (365.25 * 81)-1)

2) Date query in c_dimcode reversed and wrong numbers C_FULLNAME|C_OPERATOR|C_DIMCODE \PCORI\ENCOUNTER\Age at visit>= 65 years old\89|BETWEEN|((select birth_date from PCORI_Dev.dbo.patient_dimension where patient_num = PCORI_Dev.dbo.visit_dimension.patient_num) + (365.25 * 83)-1) AND ((select birth_date from PCORI_Dev.dbo.patient_dimension where patient_num = PCORI_Dev.dbo.visit_dimension.patient_num) + (365.25 * 82)-1)

Please review and make corrections accordingly. Thank you!

jklann commented 8 years ago

Fixed