search

ARCH-commons / arch-ontology

ARCH i2b2 PCORnet Ontology
Other
14 stars 13 forks source link

Umlauts Replaced by ? inside Diag Ontology #47

Open ConnieZ opened 7 years ago

ConnieZ commented 7 years ago

20 ICD10 codes in ForUpgradeOnly folder txt file had ? instead of 'oe' umlaut values, and in the pcornet_diag.txt v2.1.2 file they appear to have been partially fixed (c_tooltip still has ?). Was that part of the 2.1.2 fix you applied earlier?

Example: Inside ForUpgradeOnly folder - ICD10-CM-SCILHS-2015AA.zip: 6|"\PCORI\DIAGNOSIS\10(C00-D49) Neop~k3n8(C81-C96) Mali~u9p7(C88) Malignan~9aq7(C88.0) Walden~cfpb\"|"**Waldenstr?m macroglobulinemia**"|"N"|"FAE"|0|"ICD10:C88.0"||"concept_cd"|"CONCEPT_DIMENSION"|"concept_path"|"T"|"LIKE"|"\PCORI\DIAGNOSIS\10(C00-D49) Neop~k3n8(C81-C96) Mali~u9p7(C88) Malignan~9aq7(C88.0) Walden~cfpb\"||"Diagnoses \ Neoplasms (c00-d49) \ Malignant neoplasms of lymphoid, hematopoietic and related tissue (c81-c96) \ Malignant immunoproliferative diseases and certain other b-cell lymphomas \ **Waldenstr?m macroglobulinemia**"|"@"|2015/01/01 12:00:00 AM|2016/06/29 04:46:17 PM|2016/06/29 04:46:18 PM|"RPDR_2015"|||"\PCORI\DIAGNOSIS\10(C00-D49) Neop~k3n8(C81-C96) Mali~u9p7(C88) Malignan~9aq7\"|"(C88.0) Walden~cfpb"|"C88.0"

Inside pcornet_diag.zip in ontology folder 6|"\PCORI\DIAGNOSIS\10(C00-D49) Neop~k3n8(C81-C96) Mali~u9p7(C88) Malignan~9aq7(C88.0) Walden~cfpb\"|**"Waldenstroem macroglobulinemia"**|"N"|"FAE"|0|"ICD10:C88.0"||"concept_cd"|"CONCEPT_DIMENSION"|"concept_path"|"T"|"LIKE"|"\PCORI\DIAGNOSIS\10(C00-D49) Neop~k3n8(C81-C96) Mali~u9p7(C88) Malignan~9aq7(C88.0) Walden~cfpb\"||"Diagnoses \ Neoplasms (c00-d49) \ Malignant neoplasms of lymphoid, hematopoietic and related tissue (c81-c96) \ Malignant immunoproliferative diseases and certain other b-cell lymphomas \ **Waldenstr?m macroglobulinemia**"|"@"|2015/01/01 12:00:00 AM|2016/06/29 04:46:17 PM|2016/06/29 04:46:18 PM|"RPDR_2015"|||"\PCORI\DIAGNOSIS\10(C00-D49) Neop~k3n8(C81-C96) Mali~u9p7(C88) Malignan~9aq7\"|"(C88.0) Walden~cfpb"|"C88.0" This affects the following fields: c_name, c_tooltip, but not c_dimcode, so the other bug I found for 2.1.2 milestone doesn't seem to address this issue.

For consistency's sake, it would make sense to apply the change to the ForUpgradeOnly file as well.

Question: should this fix be applied consistently to both c_name and c_tooltip?

jklann commented 7 years ago

Diagnosis was out-of-date in the ForUpgradeOnly folder, oops! It is up-to-date now. Please test and close if all is ok. @ConnieZ

ConnieZ commented 7 years ago

The fix has been tested. Closing the issue.

jklann commented 7 years ago

Reopening: the SHRINE ontology still has this issue in the 2.1 release.