search

ARCH-commons / arch-ontology

ARCH i2b2 PCORnet Ontology
Other
14 stars 13 forks source link

containers (vs. folders) prevent searching for "any recorded Ethnicity" etc. #69

Open dckc opened 7 years ago

dckc commented 7 years ago

I'd like to drag the "Ethnicity" term over, i.e. search for "any recorded Ethnicity". But the the UI won't let me. The icon seems to indicate the c_visualattributes are set to Container rather than Folder.

This applies to Age, Race, Diagnosis, etc.

Is this on purpose? Please consider changing them to Folders. (I think we can do this locally, but we'd rather not have to.)

cc @contactlp, @rwaitman, @TamaraKUMC

lcphillips2 commented 7 years ago

Dan, Isnt everyone going to have an ethnicity (even if its “ethnicity not recorded” or “unknown”)?

The reason these were made containers is that they would return everyone.

Lori

From: Dan Connolly [mailto:notifications@github.com] Sent: Tuesday, August 08, 2017 11:13 AM To: SCILHS/scilhs-ontology scilhs-ontology@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [SCILHS/scilhs-ontology] containers (vs. folders) prevent searching for "any recorded Ethnicity" etc. (#69)

I'd like to drag the "Ethnicity" term over, i.e. search for "any recorded Ethnicity". But the the UI won't let me. The icon seems to indicate the c_visualattributes are set to Container rather than Folder.

This applies to Age, Race, Diagnosis, etc.

Is this on purpose? Please consider changing them to Folders. (I think we can do this locally, but we'd rather not have to.)

cc @contactlphttps://github.com/contactlp, @rwaitmanhttps://github.com/rwaitman, @TamaraKUMChttps://github.com/tamarakumc

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/SCILHS/scilhs-ontology/issues/69, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALOgczxGz41W3Y9k7fdVCsDgavM24Lvoks5sWHregaJpZM4Ow4PO.

The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.

dckc commented 7 years ago

Perhaps everyone should have an ethnicity recorded, but it's still a hypothesis I would like to be able to confirm with an i2b2 query. In particular, I wanted to do just that today in order to confirm that some SHRINE mappings were working.

lcphillips2 commented 7 years ago

I don’t have an opinion either way on whether or not this gets enabled. However I would test a Medications query before blindly enabling it. Medications in particular is going to generate a very large sql statement.

Also, I would run it by Shawn .. he may have had another reason for setting root nodes as containers.

From: Dan Connolly [mailto:notifications@github.com] Sent: Tuesday, August 08, 2017 1:59 PM To: SCILHS/scilhs-ontology scilhs-ontology@noreply.github.com Cc: Phillips, Lori C. LCPHILLIPS@PARTNERS.ORG; Comment comment@noreply.github.com Subject: Re: [SCILHS/scilhs-ontology] containers (vs. folders) prevent searching for "any recorded Ethnicity" etc. (#69)

Perhaps everyone should have an ethnicity recorded, but it's still a hypothesis I would like to be able to confirm with an i2b2 query. In particular, I wanted to do just that today in order to confirm that some SHRINE mappings were working.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/SCILHS/scilhs-ontology/issues/69#issuecomment-321033884, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALOgc0KG_NNKim2Mi_6HUgWTQ3APLZ5Tks5sWKHRgaJpZM4Ow4PO.

The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.