create sql server metadata tables needs updating

ARCH-commons / arch-ontology

ARCH i2b2 PCORnet Ontology

Other

14 stars 13 forks source link

create sql server metadata tables needs updating #75

Closed matthewjoss closed 6 years ago

matthewjoss commented 6 years ago

the file found here needs to be updated: https://github.com/ARCH-commons/arch-ontology/blob/master/Scripts/SqlServer/create_sqlserver_metadata_tables.sql

It appears to not be up to date with regards to what is needed for OMOP. For example demo is missing imaps and PCORI_SOURCECODE.

jklann commented 6 years ago

Looks like you already did this in issue #62 in August. I don't think anything else needs to be done to the ontology for OMOP right now.

matthewjoss commented 6 years ago

I think we must have added things since then because I noticed that the existing script in Github does not have OMOP_basecode or i_flags for the demo table, both of which are columns that exist in the copy you uploaded to the dropbox. Other columns were missing from other tables as well. So in order to import those tables correctly into our eMERGE project I needed to make a new DDL for that. I already did this actually, just have not pushed it up to github yet.