*_TIME fields are using 12 hour clock not 24 hour clock

ARCH-commons / i2p-transform

i2b2 to PCORnet Common Data Model Transformation - requires i2b2 PCORnet ontology

Other

3 stars 16 forks source link

*_TIME fields are using 12 hour clock not 24 hour clock #13

Closed keithwanta closed 7 years ago

keithwanta commented 8 years ago

The *_TIME fields in the CDM are built based on a 12 hour clock. For example, a date with a time of 00:00:00 get converted to 12:00. This might be a problem for encounters that result from dispensed medications. I suppose BIRTH_TIME might be critical for certain metrics, if the time wasn't properly converted.

dckc commented 8 years ago

@ngraham @mprittie I wonder if our times got mangled because of this. I suppose the fix is to use HH24 instead of HH somewhere.

matthewjoss commented 7 years ago

Fixed in Oracle.

dckc commented 7 years ago

Where exactly was this fixed? Which revision?

matthewjoss commented 7 years ago

That was all in the 83c696a commit

dckc commented 7 years ago

Thanks.