search

ARCH-commons / i2p-transform

i2b2 to PCORnet Common Data Model Transformation - requires i2b2 PCORnet ontology
Other
3 stars 16 forks source link

PCORNet diagnosis table replication errors #35

Closed jklann closed 7 years ago

jklann commented 7 years ago

In the PCORnet diagnosis transform, admit_date and provider_id should source its value from the encounter table, not factline

matthewjoss commented 7 years ago

Fixed in both transforms... although 'provider_id' needs to be tested properly on real data

jklann commented 7 years ago

Hmm, I don't think I intended the joins to reference the encounter table, just the select statement. I changed it back and am testing.

jklann commented 7 years ago

Oh, I only changed it back in MSSQL for testing.

jklann commented 7 years ago

I think the status is this needs to be tested in Oracle