search

ARCH-commons / i2p-transform

i2b2 to PCORnet Common Data Model Transformation - requires i2b2 PCORnet ontology
Other
3 stars 16 forks source link

pcornet_parsecode fails on NULL value in "codestring" parameter #8

Closed keithwanta closed 8 years ago

keithwanta commented 8 years ago

The procedure pcornet_parsecode in PCORNETLoader_ora.sql (Oracle script) should either check for a NULL value in the codestring parameter. Or the code (or procedure) that calls it should check for an argument value of NULL for the codestring parameter.

There's a conflict of interest here. PCORNET_DEMO doesn't allow NULL values in C_DIMCODE, yet the ontology has NULL values in C_DIMCODE.

Do I trust the data (in the i2p-ontology repo) or the Oracle source code? Looks like the source code matches the DDL, so that's good. This question also applies to the other ontologies with NULL values in this field.

jklann commented 8 years ago

Looking at the code, it appears that strings are skipped if it is not a quoted, comma-separated list. And the null issue in the dimcode is fixed now over in the ontology repo. If this is resolved, can you close it? Thanks.

keithwanta commented 8 years ago

Resolved. Closing for now.