search

ARCLeeds / arcleeds.github.io

Research Computing at Leeds Website
https://arcleeds.github.io/
MIT License
1 stars 2 forks source link

New training page #225

Closed patricia-ternes closed 2 months ago

patricia-ternes commented 2 months ago

Note: I did this on Grasi's laptop, so it is her name on commits, sorry about it.

This pull request creates a new training page. How it works:

  1. The pages/training.md was updated to retrieve information from _data/events.yml
  2. For each event in _data/events.yml a banner will be created using the template available in _includes/event.html (and the style defined in _sass/_12_events-calendar.scss).
    • Note that the information under each event in _data/events.yml is minimum because I am using the course code to retrieve the course information from _data/training_courses.yml.
    • DataVis has no information under the _data/training_courses.yml, so one of the banners is empty, we can fix this later on.
  3. The pages/training.md code verifies the date and display only future events. So in theory, it is not necessary delete old events. But I am not sure how this will be handled in future by the GH action.

This PR override the PR #223, so if this one is approved, the #223 should be deleted.

patricia-ternes commented 2 months ago

As we discussed, the calendar page was not necessary anymore, so I removed. I also removed the Courses page as this is not updated and the information may lead to wrong assumptions. I will create a Issue related to this. So we can accept/close this PR and handle the Courses page in other moment.

I will also create a Issue for the DataVis course description.