search

ARETEedu / moodle-mod_arete

A repository service for Augmented Reality Learning Experience Models (compliant with IEEE p1589-2020)
GNU General Public License v3.0
3 stars 2 forks source link

96 download thumbnail #109

Open Callustian opened 1 year ago

Callustian commented 1 year ago

Adding downloading thumbnail feature

Callustian commented 1 year ago

Linked to #96

jafarigit commented 1 year ago

Here also conflicts needs to be resolved anyway

jafarigit commented 1 year ago

Fails the postman test, not quite sure why.

I believe the test can also be executed in postman (either local or using postman web), and this is the test file: https://github.com/ARETEedu/moodle-mod_arete/blob/develop/tests/postman/Moodle%20Arete.postman_collection.json

Essentially, the upload test seems to fail, see last pipeline action run: https://github.com/ARETEedu/moodle-mod_arete/actions/runs/5414182421/jobs/9841087368

Weirdly, it looks like the test before that is trying to delete the file, so this may just be a bit messed up…?

To fix, I would recommend to run the tests in postman from a local postman (so that the upload tests have access to the two local files in the tests folder: https://github.com/ARETEedu/moodle-mod_arete/tree/develop/tests/postman - and either fix the test (if obvious) or remove the test. but it may also fix it if we merge in the remaining two open PR requests? As one of them (119) does changes in the test: https://github.com/ARETEedu/moodle-mod_arete/pull/120/files

Unfortunately, I'm not familier with the PHP testing that much. I just testet the plugin and every thing seems work like before. therefore I merge them. So I don't know what changes have been done on test file by @geopsirra that made tests failed.