Extract methods to interfaces & change way of providing dependencies

ARK-Builders / ARK-Memo

ARK Memo is one app for all of your notes: it's aiming to combine plain text, voice and hand-written notes

MIT License

2 stars 3 forks source link

Extract methods to interfaces & change way of providing dependencies #25

Closed hieuwu closed 11 months ago

hieuwu commented 11 months ago

:rocket: Summary

Extract methods to interfaces & change way of providing dependencies Part 1 of #24

Avoid usage of manual singleton, replace with singleton component
Extract methods to interface to make the app ready for TDD

All new repository created must follow the principle programming over abstraction instead of implementation. They should be provided in di and as a module

hieuwu commented 11 months ago

TextNotesRepo interface should be renamed NotesRepo and TextNotesRepoImpl to just TextNotesRepo. We will have other note type repos implement it

Got your point. However, let's keep one implementation for one interface as it is current approach. If in the future we add more, let's consider later.

hieuwu commented 11 months ago

We should migrate to Datastore later https://developer.android.com/topic/libraries/architecture/datastore

I just change the way to provide dependencies. If we need to migrate to data store, we should do it later