ARK-Builders / ARK-Memo

ARK Memo is one app for all of your notes: it's aiming to combine plain text, voice and hand-written notes
MIT License
2 stars 3 forks source link

Support batch deletion #47

Open tuancoltech opened 9 months ago

tuancoltech commented 9 months ago

Problem: Right now there's no way to delete notes in batch. We have to to it one by one.

We should support deleting multiple notes at once since it's much more convenient for users.

Screenshot 2024-01-11 at 22 46 27
kirillt commented 9 months ago

Good idea, also we need "delete all versions" feature. Not sure though if it should delete all parents or all parent and all children?

tuancoltech commented 6 months ago

Good idea, also we need "delete all versions" feature. Not sure though if it should delete all parents or all parent and all children?

@kirillt By versions, do you mean the notes created by modifying an existing note? And by parent, do you mean the very first note from which versions are created?

kirillt commented 6 months ago

@tuancoltech yep, children are created by modifying a note and tracked in versions storage. Parent-children relation forms tree-like structure (1 parent can have multiple children, but a child cannot have more than 1 parent). In strict sense, a parent is only immediate parent of a child, I meant all ancestors in my previous message.

tuancoltech commented 6 months ago

@tuancoltech yep, children are created by modifying a note and tracked in versions storage. Parent-children relation forms tree-like structure (1 parent can have multiple children, but a child cannot have more than 1 parent). In strict sense, a parent is only immediate parent of a child, I meant all ancestors in my previous message.

@kirillt I see. So you was wondering if we should delete all ancestors excluding the latest modification of the note, or all of them including the last modification.

That makes sense. From my point of view we should keep the last modified note, as it's normally the most updated one in a way that users really want it to be.

We can do it in another PR as it's not directly related to the purpose of this PR.