search

ARK-Builders / ARK-Navigator

Android app for navigation through your data
MIT License
15 stars 15 forks source link

Tags are not displayed when added from another root folder #111

Closed melvin4u445 closed 2 years ago

melvin4u445 commented 2 years ago

I have added the following folders as separate root folders:

I opened Manage Folders>Compass button on DCIM/Screeshots, opened an image and added a tag to it. Then I opened Manage Folders>Compass button on DCIM and checked if the newly added tag is listed. Turns out it's not listed.

It would make sense that the newly added tag is displayed when opening DCIM root since DCIM/Screenshots is a subfolder of that folder

kirillt commented 2 years ago

Wait, it should be forbidden to add nested roots. If a user wants nested folder, they have to add favorite. Did you add DCIM/Screenshots before you added DCIM. Otherwise, folder picker automatically changes "Add root" to "Add favorite" when you enter a root folder.

"Root" is a folder where we store the tags database (.ark-tags file). We might scan all subfoldera for them, but it should be considered as separate feature. I'm not sure yet if it's really useful, but we might implement it later.

melvin4u445 commented 2 years ago

Yeah, I added DCIM/Screenshots before adding DCIM

"Root" is a folder where we store the tags database (.ark-tags file)

What happens if a file is moved to another folder? Will it lose all its tags?

melvin4u445 commented 2 years ago

Raised #112 to address the nested folder issue

kirillt commented 2 years ago

@melvin4u445

What happens if a file is moved to another folder? Will it lose all its tags?

Right, all tags will be lost.

Closing this issue since it actually wasn't intended to work this way, but downgrading a root into a favorite would be cool feature.