Sorting should be case insensitive

ARK-Builders / ARK-Navigator

Android app for navigation through your data

MIT License

15 stars 15 forks source link

Sorting should be case insensitive #200

Closed melvin4u445 closed 2 years ago

melvin4u445 commented 2 years ago

Files starting with a capital letter are shown first and files starting with a small letter are shown after that.

melvin4u445 commented 2 years ago

About files names starting with special characters:

If files are sorted in ascending order, they should be at the top of the list
If files are sorted in descending order, they should be at the bottom of the list

Is that the expected behaviour?

kirillt commented 2 years ago

I think it's difficult to determine what is desired regarding order of special characters.. Maybe we should just eliminate sorting by name sometimes :)

sisco0 commented 2 years ago

Could you kindly check if the version at the branch shown below solves this issue? https://github.com/sisco0/ARK-Navigator/tree/feat/issue-200-case-insensitive-order

The changes are summarized in the last commit of the given branch. A small change is required for setting an extra parameter to the compareBy function. The given version only serves as reference and it is not meant to be merged into the main project repository.

kirillt commented 2 years ago

@sisco0 sorry for late response, I'm still working on my GitHub habits.. Thank you, your commit looks perfectly fine, don't hesitate to submit pull-request. Actually, I would notice PR quicker than mentioning :) Also don't hesitate to reach me in Telegram (@kirill_taran) or by e-mail (kirill@taran.space) for discussing paid tasks.