ARK-Builders / ARK-Navigator

Android app for navigation through your data
MIT License
15 stars 15 forks source link

Catch up to arklib #56 #355

Closed kirillt closed 1 year ago

kirillt commented 1 year ago

https://github.com/ARK-Builders/arklib-android/pull/56

Opening folders created before this PR might require erasure of .ark/meta folder.

Current bugs of this PR:

kirillt commented 1 year ago

Enabling it for all resources without preview might be useful for debugging too: https://github.com/ARK-Builders/ARK-Navigator/issues/205

kirillt commented 1 year ago

When returning from Retouch and the resource was overwritten:

http://65.21.4.137:8080/app/1/bug/251/report/cddfdbab-5d7f-427e-ae73-39ee4c840c4b

java.lang.IllegalStateException: Index is not up-to-date regarding path /storage/emulated/0/Pictures/Screenshots/Screenshot_20230722-164758_ARK Retouch.png
    at space.taran.arknavigator.mvp.presenter.GalleryPresenter$checkResourceChanges$1.invokeSuspend(GalleryPresenter.kt:373)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
    at kotlinx.coroutines.internal.LimitedDispatcher.run(LimitedDispatcher.kt:42)
    at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:95)
kirillt commented 1 year ago

Not everything is perfect, but we have new impressive functionality and rebuilt many things from ground-up. We have to find performance bottlenecks in the current implementation and improve it in the nearest future.