search

ARK-Builders / ARK-Navigator

Android app for navigation through your data
MIT License
15 stars 15 forks source link

Improve CI by reduce dependency between steps #437

Closed hieuwu closed 7 months ago

hieuwu commented 7 months ago

:rocket: Summary

Currently, total time taken to complete the whole build for each commit is ~10mins. Build - 5 mins Test - 2 mins (depends on build) Lint and Klint - 2 mins (depends on test) It takes about 7 mins before linting to be run while it is unnecessary making linting depends on test and build. Other than that, linting can be requested to be fixed by reviewer before they approve the PR, hence it is fine to keep linting out of build or test steps

✅ Solution

By removing the dependency on test, linting could be run separately, it would reduce total time it takes to complete the build from 10mins to 8mins or faster Result

Screenshot 2024-02-12 at 15 22 37
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

kirillt commented 7 months ago

@hieuwu does this PR affect time to generate artifacts? If yes, then maybe we should depend on build step.

hieuwu commented 7 months ago

@hieuwu does this PR affect time to generate artifacts? If yes, then maybe we should depend on build step.

It does not affect to any artifact uploading but all the artifacts are only available when all job are completed.