search

ARK-Builders / ARK-Rate

ARK Rate is a tiny convenience app for quickly converting multiple currencies at the same time
https://www.ark-builders.dev/apps/rate/
MIT License
2 stars 2 forks source link

Fixes for Play Protect alarm #49

Closed MohamedPresident closed 11 months ago

MohamedPresident commented 11 months ago

Migrate from kapt to ksp

Update jvm from 2.8 to 17

tuancoltech commented 11 months ago

@MohamedPresident Please amend the commit message, and the PR title/description to reflect the purpose of this change.

tuancoltech commented 11 months ago

@MohamedPresident As far as I got, you've been trying to solve the below issue? If that's the case, could you share what is the cause of the issue, and how you would solve it with your changes?

Screenshot 2023-12-04 at 22 11 37

MohamedPresident commented 11 months ago

@MohamedPresident As far as I got, you've been trying to solve the below issue? If that's the case, could you share what is the cause of the issue, and how you would solve it with your changes?

Screenshot 2023-12-04 at 22 11 37

Actually Play Protect alarm is a tricky issue and many factors can cause it:

1/ Unnecessary external libraries can raise Play Protect Alarm so I migrated from kapt to ksp because I found that ksp API already existed without migration.

2/ Using Old Android Gradle Plugin version and old sourceCompatibility is bad practice and can cause the Play Protect alarm indirectly.