search

ARK-Builders / ark-core

The core of the ARK framework
MIT License
4 stars 3 forks source link

Update Clippy command and Fix Clippy warnings #66

Closed tareknaser closed 4 months ago

tareknaser commented 4 months ago

Description:

This pull request includes two changes:

  1. Refactoring to address Clippy warnings.
  2. Updating the Clippy command in the build workflow to include additional flags to improve linting coverage.

Fixes #53

github-actions[bot] commented 4 months ago

Benchmark for cc4930a

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | ../test-assets/lena.jpg/compute_bytes | 13.9±0.05µs | 13.9±0.10µs | 0.00% | | ../test-assets/test.pdf/compute_bytes | **111.0±0.80µs** | 112.0±0.93µs | **+0.90%** | | compute_bytes_large/compute_bytes | 248.3±4.69µs | **143.7±1.70µs** | **-42.13%** | | compute_bytes_medium/compute_bytes | **27.2±0.31µs** | 29.8±0.20µs | **+9.56%** | | compute_bytes_small/compute_bytes | 131.5±3.74ns | 131.1±2.02ns | -0.30% | | index_build/index_build/../test-assets/ | 160.4±1.05µs | 160.9±0.70µs | +0.31% |
kirillt commented 4 months ago

@tareknaser good PR, thanks! Could you also take this contributing instruction from Navigator, proofread it and copy to ark-rust repo as CONTRIBUTE.md?

I'll refer it from the clippy issue.

github-actions[bot] commented 4 months ago

Benchmark for 35142f9

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | blake3_resource_id_creation/compute_from_bytes:large | **249.5±1.44µs** | 252.7±0.93µs | **+1.28%** | | blake3_resource_id_creation/compute_from_bytes:medium | 15.6±0.11µs | 15.6±0.07µs | 0.00% | | blake3_resource_id_creation/compute_from_bytes:small | 1346.3±10.27ns | 1348.2±2.84ns | +0.14% | | blake3_resource_id_creation/compute_from_path:../test-assets/lena.jpg | 196.0±2.11µs | 196.3±1.30µs | +0.15% | | blake3_resource_id_creation/compute_from_path:../test-assets/test.pdf | **1722.5±4.11µs** | 1733.2±15.38µs | **+0.62%** | | crc32_resource_id_creation/compute_from_bytes:large | 86.7±1.23µs | 86.6±0.44µs | -0.12% | | crc32_resource_id_creation/compute_from_bytes:medium | 5.4±0.02µs | 5.4±0.04µs | 0.00% | | crc32_resource_id_creation/compute_from_bytes:small | 92.3±0.24ns | 92.3±0.29ns | 0.00% | | crc32_resource_id_creation/compute_from_path:../test-assets/lena.jpg | **63.9±0.17µs** | 64.4±0.26µs | **+0.78%** | | crc32_resource_id_creation/compute_from_path:../test-assets/test.pdf | **918.9±7.69µs** | 924.0±2.89µs | **+0.56%** | | index_build/index_build/../test-assets/ | 1070.0±3.00µs | **1066.5±6.26µs** | **-0.33%** |