ARK-Builders / arklib

Core of the programs in ARK family
MIT License
1 stars 10 forks source link

Function `update_one` cannot accept `CanonicalPathBuf` for deleted files #45

Closed kirillt closed 8 months ago

kirillt commented 10 months ago

This is an oversight of implementation in #42

See #38 for more context. TL;DR: We use update_one for cases when a resource by some path changed or was deleted at all. We can't canonicalize a non-existent path, so we fail to call update_one in this case. This API should receive plain Path-like type: Path, PathBuf or be generic with AsRef<Path>.

kirillt commented 9 months ago

This is necessary for this PR: