search

ARK-Builders / arklib

Core of the programs in ARK family
MIT License
1 stars 10 forks source link

#41: Add unit tests, fix update_one #72

Open kirillt opened 6 months ago

kirillt commented 6 months ago

Here are couple more tests.

update_one was handling absent paths incorrectly, fixed here.

Closing:

kirillt commented 6 months ago
funnyVOLT commented 6 months ago

@kirillt I would like to inform you of my opinion. The problem occurred while comparing 'update_all' and 'track_methods'.

  1. When a new file is created. When files with the same ResourceID are added, update_all and track_addition operate differently.
  2. When a new file is modified After the file is changed, update_all does not seem to reflect the changed information. The handling of collisions in the 'track_update' function is not reflected clearly.
  3. Overall, I think we need to check 'collisions' again.
kirillt commented 6 months ago

@funnyVOLT thank you for the test case. I'll look into it deeper soon. It's great that you've discovered corner cases I've missed!

Could you create small isolated test cases reproducing these 2 problems?

  1. When files with the same ResourceID are added, update_all and track_addition operate differently.

    1. After the file is changed, update_all does not seem to reflect the changed information.
funnyVOLT commented 6 months ago

@funnyVOLT thank you for the test case. I'll look into it deeper soon. It's great that you've discovered corner cases I've missed!

Could you create small isolated test cases reproducing these 2 problems?

  1. When files with the same ResourceID are added, update_all and track_addition operate differently.

  2. After the file is changed, update_all does not seem to reflect the changed information.

@kirillt , I've pushed test case codes.