#65: Replace `CRC32` with `BLAKE3` Hash Function

tareknaser commented 8 months ago

Description

This pull request updates the hashing method for the ResourceId struct, replacing CRC32 with BLAKE3 hash function. Related Issue: #65

Changes

The changes include:

Addition of benchmarks for the ResourceId::compute_bytes method using the criterion crate with the html_reports feature enabled. Run cargo bench to generate benchmarks in the /target/criterion folder
Removing collision handling as BLAKE3 is a cryptographic hash function

Refer to individual commit messages and bodies for detailed information

kirillt commented 8 months ago

Let's finish the benchmarks first:

74

After we have index benchmark, we'll be able to judge better about performance penalty of Blake3. Collision tracking, necessary for CRC32, could eat some performance up, too.

tareknaser commented 6 months ago

This PR should be rewritten when https://github.com/ARK-Builders/arklib/pull/90 is merged here and into ark-rust as well.

I can re rewrite the logic in ark-rust directly so that it implements ResourceIdTrait

tareknaser commented 5 months ago

Closing this in favor of https://github.com/ARK-Builders/ark-rust/pull/32

ARK-Builders / arklib

#65: Replace `CRC32` with `BLAKE3` Hash Function #73

Description

Changes

74