search

ARM-DOE / ACT

Atmospheric data Community Toolkit - A python based toolkit for exploring and analyzing time series atmospheric datasets
https://ARM-DOE.github.io/ACT/
Other
138 stars 35 forks source link

ENH: Rename the csv module to prevent errors #788

Closed mgrover1 closed 8 months ago

mgrover1 commented 8 months ago

Rename the csv module to text

zssherman commented 8 months ago

@mgrover1 Looks good to me, failing test seems to be an import error still, the doc build fail is strange as we don't pin sphinx, maybe because we pip install it in the enviromnet_docs.yml and its pip installing an earlier version?

zssherman commented 8 months ago

@mgrover1 Looks like pysp2 doc is failing due to sphinx as well, wonder if sphinx did an update...

mgrover1 commented 8 months ago

Yes, it is happening across the Pythia sphere as well

zssherman commented 8 months ago

@mgrover1 Ah makes sense.... yeah was digging through sphinx and couldn't find anything, can you reference one of the pythia issues here?

mgrover1 commented 8 months ago

see the discussion here https://github.com/ProjectPythia/cookbook-template/issues/154

zssherman commented 8 months ago

@mgrover1 Pushed an attempted fix commit for the path in noaapsl. Not sure why the path is failing there but not in neon.py etc. We might have to dig further on the cause.

zssherman commented 8 months ago

@mgrover1 found the problem think its fixed.

zssherman commented 8 months ago

Surprised that didn't fix the issue...

mgrover1 commented 8 months ago

@zssherman - the act.io.noaapsl submodule's import was inconsistent - I pushed a fix

zssherman commented 8 months ago

@mgrover1 I added in the noaa psl change to test it out, but the init change was missing text instead of csv for the top module. Thought that would have fixed the issue when I changed that

mgrover1 commented 8 months ago

It would help if the submodule were actually added... that last push should resolve the issues 👍

mgrover1 commented 8 months ago

@rcjackson - this is a solid state now - do you have the PR ready to merge or do a release of PySP2

rcjackson commented 8 months ago

New release of PySP2 is out on PyPI, so once that gets through these unit tests should succeed. PySP2's are succeeding on my machine with @mgrover1 's fork installed though currently failing online because this PR and release is not done.

AdamTheisen commented 8 months ago

@zssherman would you want to get a new release done today?

zssherman commented 8 months ago

@AdamTheisen Yeah, I can do that!

zssherman commented 8 months ago

@AdamTheisen An issue with the PySP2 release, going to get that fix, then can do the ACT release

mgrover1 commented 8 months ago

Can I hit merge?

zssherman commented 8 months ago

@mgrover1 Yep was waiting on pysp2 to catch up!