search

ARM-DOE / ACT

Atmospheric data Community Toolkit - A python based toolkit for exploring and analyzing time series atmospheric datasets
https://ARM-DOE.github.io/ACT/
Other
133 stars 34 forks source link

Unit conversion warning #795

Closed kenkehoe closed 5 months ago

kenkehoe commented 5 months ago

This adds keywords to the convert_units method to notify user when the conversion fail. Because of how the method can loop through all the variables in the Dataset we don't want to print or raise exceptions when a conversion fails. This adds options the user can implement. I tried to use warnings but they didn't work so it's a print statement.

zssherman commented 5 months ago

@kenkehoe Thanks for the PR! I added a few comments

kenkehoe commented 5 months ago

@zssherman I removed the old code and submitted a job to run. I assume you can make the failing part of this process more better? I don't think it's something on my end.

zssherman commented 5 months ago

@kenkehoe Thanks for the changes! Yeah it was a stalled test. Should be rerunning now