ARM-DOE / ACT

Atmospheric data Community Toolkit - A python based toolkit for exploring and analyzing time series atmospheric datasets
https://ARM-DOE.github.io/ACT/
Other
138 stars 35 forks source link

CI: Add linting action that uses pre-commit and ruff. #797

Closed zssherman closed 7 months ago

zssherman commented 8 months ago

I need to find a way for it to ignore removing the imports in the try and except blocks

zssherman commented 7 months ago

@mgrover1 Is there a way for precommit to fix the 600 or so long line errors? Or do i have to manually go in and fix all 600.... Or is there another way around it?

mgrover1 commented 7 months ago

@zssherman - you can fix these files using ruff, which is part of the pre-commit hooks

See https://docs.astral.sh/ruff/tutorial/#getting-started

You can run

ruff check . --fix

to automatically go in and fix those files

zssherman commented 7 months ago

@mgrover1 Hmm sadly it doesn't do anything at all from the act directory.

zssherman commented 7 months ago

@mgrover1 I think I figured it out, was missing that addition of ruff to the pyproject.yml