Correctly set movie duration for conversion

ARM-DOE / ACT

Atmospheric data Community Toolkit - A python based toolkit for exploring and analyzing time series atmospheric datasets

https://ARM-DOE.github.io/ACT/

Other

138 stars 35 forks source link

Correctly set movie duration for conversion #818

Closed kenkehoe closed 6 months ago

kenkehoe commented 6 months ago

generate_movie() uses moviepy to convert a mpg to other format. If the mpg movie does not have duration parameter set moviepy will guess incorrectly and the converted movie is too short. Adding code to loop through mpg movie to get correct duration for conversion.

[ X] Tests added
[X ] Documentation reflects changes
[ X] PEP8 Standards or use of linter
[ X] Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

zssherman commented 6 months ago

@kenkehoe Thanks for the PR! Looks like some PEP8 fixes are needed.