Closed isilber closed 2 years ago
@isilber let me know when you want me to take a look! I am willing to provide feedback!
@mgrover1 you are welcome to take a look, thanks! Note that the notebook requires the recent EMC2 commits, pushed after the v. 1.2 release (Bobby will soon make a new release on conda-forge).
View / edit / reply to this conversation on ReviewNB
mgrover1 commented on 2022-05-03T18:30:35Z ----------------------------------------------------------------
Can you add some other subsections (ex. imports, overview of instruments, etc.)
View / edit / reply to this conversation on ReviewNB
mgrover1 commented on 2022-05-03T18:30:35Z ----------------------------------------------------------------
Can you break this up a bit more? Add a little more narration?
View / edit / reply to this conversation on ReviewNB
mgrover1 commented on 2022-05-03T18:30:36Z ----------------------------------------------------------------
Can you make this list at the end? ex. resources?
Great work @isilber ! I left a few comments - feel free to take a look/make some changes!
Thanks for the feedback, @mgrover1 . I updated the files accordingly.
@isilber one other small request - can you modify the path to your data file to be in a /data
directory in the /tutorials
directory?
Done
@isilber do you mind if I go ahead and merge?
Go ahead
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB