search

ARM-Development / ARM-Notebooks

Repository for holding notebooks related to ARM data
https://arm-development.github.io/ARM-Notebooks
8 stars 20 forks source link

ADD EMC2 tutorial notebook and presentation #16

Closed isilber closed 2 years ago

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mgrover1 commented 2 years ago

@isilber let me know when you want me to take a look! I am willing to provide feedback!

isilber commented 2 years ago

@mgrover1 you are welcome to take a look, thanks! Note that the notebook requires the recent EMC2 commits, pushed after the v. 1.2 release (Bobby will soon make a new release on conda-forge).

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

mgrover1 commented on 2022-05-03T18:30:35Z ----------------------------------------------------------------

Can you add some other subsections (ex. imports, overview of instruments, etc.)


review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

mgrover1 commented on 2022-05-03T18:30:35Z ----------------------------------------------------------------

Can you break this up a bit more? Add a little more narration?


review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

mgrover1 commented on 2022-05-03T18:30:36Z ----------------------------------------------------------------

Can you make this list at the end? ex. resources?


mgrover1 commented 2 years ago

Great work @isilber ! I left a few comments - feel free to take a look/make some changes!

isilber commented 2 years ago

Thanks for the feedback, @mgrover1 . I updated the files accordingly.

mgrover1 commented 2 years ago

@isilber one other small request - can you modify the path to your data file to be in a /data directory in the /tutorials directory?

isilber commented 2 years ago

Done

mgrover1 commented 2 years ago

@isilber do you mind if I go ahead and merge?

isilber commented 2 years ago

Go ahead

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.