search

ARM-Development / ARM-Notebooks

Repository for holding notebooks related to ARM data
https://arm-development.github.io/ARM-Notebooks
8 stars 20 forks source link

ADD: Adding jupyter hub notebook #55

Closed zssherman closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

zssherman commented 1 year ago

@AdamTheisen Let me know if this looks good

AdamTheisen commented 1 year ago

@zssherman looking good! The only thing I would say is that you may want to walk them through getting into ARM's JupyterHub instance https://jupyterhub.arm.gov/, since that's where we will have them work and move the terminal test to the beginning and have them clone the ARM-Notebooks repo so they can bring up the tutorial notebooks. Does that sound reasonable?

zssherman commented 1 year ago

@AdamTheisen Yeah sounds good! I'll make the changes.

zssherman commented 1 year ago

@AdamTheisen Made the changes to include the info on ARM jupyterhub and git cloning the notebooks.

AdamTheisen commented 1 year ago

Looks good! Thanks!