search

ARM-software / CMSIS-DSP

CMSIS-DSP embedded compute library for Cortex-M and Cortex-A
https://arm-software.github.io/CMSIS-DSP
Apache License 2.0
459 stars 123 forks source link

Fix pragma clang warning with gcc #100

Closed XenuIsWatching closed 10 months ago

XenuIsWatching commented 1 year ago

When compiling with gcc a warning will appear for #pragma clang as it will be ignored. Add a conditional compile so only armclang will see the pragma clang.

XenuIsWatching commented 11 months ago

@christophe0606 Any reason why this is still "to be reviewed"?

christophe0606 commented 11 months ago

@XenuIsWatching Sorry for taking so much time to merge it. It has not been forgotten but I have had little time to focus on CMSIS-DSP for the past few months.

I'll come back to it when I prepare the next release of CMSIS-DSP.

christophe0606 commented 11 months ago

@XenuIsWatching For this PR I need to check with normal clang (for environment like windows on arm), arm clang and a gcc for aarch64. I am mainly focusing on Cortex-M so validation for aarch64 is generally taking more time since I don't always have the right environment ready.

christophe0606 commented 10 months ago

I have made a small change so that the pragma is also used when building with Xcode and not just armclang.

I have merged it in https://github.com/ARM-software/CMSIS-DSP/commit/8f8bb8d56b346274c9b2918928f2d5c3dae51758