Possible bug in `CpuIm2ColKernel.cpp`

ARM-software / ComputeLibrary

The Compute Library is a set of computer vision and machine learning functions optimised for both Arm CPUs and GPUs using SIMD technologies.

2.87k stars 782 forks source link

Possible bug in `CpuIm2ColKernel.cpp` #1140

Closed VladislavZavadskyy closed 6 days ago

VladislavZavadskyy commented 2 months ago

Hello, I'm trying to make sense of the code, and stumbled onto this piece of code:

_convolved_dims  = scaled_dimensions(src->dimension(width_idx), dst->dimension(height_idx), _kernel_width,
                                     _kernel_height, _conv_info, _dilation);

Shouldn't it be src->dimension(height_idx)?

Sorry in advance if this is intended, as I've said I'm only trying to make sense of it all, to add a custom kernel. I would be grateful if you could explain why dst is there, if it's not a bug. Thanks!

morgolock commented 1 month ago

Hi @VladislavZavadskyy

Thanks for raising this. This patch solves the problem.

Hope this helps