search

ARM-software / LLVM-embedded-toolchain-for-Arm

A project dedicated to building LLVM toolchain for 32-bit Arm embedded targets.
Apache License 2.0
377 stars 85 forks source link

Fix example build from source command lines #408

Closed voltur01 closed 3 months ago

voltur01 commented 4 months ago

Fixes https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/issues/404

AlfieRichardsArm commented 3 months ago

Why does this need to construct a absolute path rather than using a relative path?

ie. using

pwd\`/../patches/llvm-project/*.patch

Instead of the more standard

../patches/llvm-project/*.patch

which should do the same thing?

statham-arm commented 3 months ago

That part makes sense to me. It's because the overall command is using git -C, meaning "change to some other directory before running the git command". So the relative path ../foo would be interpreted relative to the cwd after git changes dir. But we want a path relative to where we are before git changes dir.

AlfieRichardsArm commented 3 months ago

Ahhh thank you @statham-arm, that makes sense