Open nsz-arm opened 1 year ago
NIT maybe the draft could be dropped now from the name of the PR.
potential issues with current spec:
- gcs store intrinsic is missing
I'm not sure we need this. We can always add it later if there's a need.
- const void vs void gcs (modified by bl/ret/... instructions, but normal c language stores don't work on it)
I think we only really need the pointer to be non-const if we have a gcs store intrinsic. constness is only about if the user is permitted to write to something, so entries on the gcs stack being modified by bl/ret isn't relevant.
- intrinsic availability check (feature test macros no longer imply intrinsics)
Is this about https://github.com/ARM-software/acle/pull/214? I think the way GCS intrinsics are currently described is OK with regards to that (though I have a couple of comments on the wording).
LGTM.
name: Pull request about: Technical issues, document format problems, bugs in scripts or feature proposal.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution guidelines, in particular the section on submitting a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below checklist.
Checklist: (mark with
X
those which apply)SPDX-FileCopyrightText
lines on top of any file I have edited. Format isSPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
(Please update existing copyright lines if applicable. You can specify year ranges with hyphen , as in2017-2019
, and use commas to separate gaps, as in2018-2020, 2022
).Copyright
section of the sources of the specification I have edited (this will show up in the text rendered in the PDF and other output format supported). The format is the same described in the previous item.draftversion
is set totrue
in the YAML header of the sources of the specifications I have modified.