ARM-software / acle

Arm C Language Extensions (ACLE)
Other
85 stars 54 forks source link

[FMV] Fix incorrect system register dependencies. #322

Closed labrinea closed 2 months ago

labrinea commented 3 months ago

Some features are later versions of others, like sve2 and sve, therefore performing equality checks on system register values would incur incorrect feature detection on later hardware. See https://github.com/ARM-software/acle/issues/320 for example. Therefore we should instead do >= comparisons when HWCAP info is not available.

I am also fixing incorrect detection for LSE and WFxT. Lastly to detect SVE2 and SME2 I am using the SVEVer and SMEVer bitfields respectively.


name: Pull request about: Technical issues, document format problems, bugs in scripts or feature proposal.


Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution guidelines, in particular the section on submitting a proposal.

Please use the proposal label.

As for any pull request, please make sure to go through the below checklist.

Checklist: (mark with X those which apply)

ilinpv commented 3 months ago

@DanielKristofKiss @Wilco1 @andrewcarlotti