[FMV] Unify sha1, sha2.

[labrinea]

According to ArmARM:

SHA2, bits [15:12] 0b0000 No SHA2 instructions implemented. FEAT_SHA256 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA1 is 0b0000, this field must have the value 0b0000.

SHA1, bits [11:8] 0b0000 No SHA1 instructions implemented. FEAT_SHA1 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA2 is 0b0000, this field must have the value 0b0000.

To my understanding this means you can't have one without the other.

---

name: Pull request about: Technical issues, document format problems, bugs in scripts or feature proposal.

---

Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution guidelines, in particular the section on submitting a proposal.

Please use the proposal label.

As for any pull request, please make sure to go through the below checklist.

Checklist: (mark with X those which apply)

• [ ] If an issue reporting the bug exists, I have mentioned it in the PR (do not bother creating the issue if all you want to do is fixing the bug yourself).
• [ ] I have added/updated the SPDX-FileCopyrightText lines on top of any file I have edited. Format is SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}> (Please update existing copyright lines if applicable. You can specify year ranges with hyphen , as in 2017-2019, and use commas to separate gaps, as in 2018-2020, 2022).
• [ ] I have updated the Copyright section of the sources of the specification I have edited (this will show up in the text rendered in the PDF and other output format supported). The format is the same described in the previous item.
• [ ] I have run the CI scripts (if applicable, as they might be tricky to set up on non-*nix machines). The sequence can be found in the contribution guidelines. Don't worry if you cannot run these scripts on your machine, your patch will be automatically checked in the Actions of the pull request.
• [ ] I have added an item that describes the changes I have introduced in this PR in the section Changes for next release of the section Change Control/Document history of the document. Create Changes for next release if it does not exist. Notice that changes that are not modifying the content and rendering of the specifications (both HTML and PDF) do not need to be listed.
• [ ] When modifying content and/or its rendering, I have checked the correctness of the result in the PDF output (please refer to the instructions on how to build the PDFs locally).
• [ ] The variable draftversion is set to true in the YAML header of the sources of the specifications I have modified.
• [ ] Please DO NOT add my GitHub profile to the list of contributors in the README page of the project.

[labrinea]

@DanielKristofKiss @jroelofs @tmatheson-arm @andrewcarlotti

[andrewcarlotti]

LGTM.

[DanielKristofKiss]

SHA2, bits [15:12] 0b0000 No SHA2 instructions implemented. FEAT_SHA256 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA1 is 0b0000, this field must have the value 0b0000.

SHA1, bits [11:8] 0b0000 No SHA1 instructions implemented. FEAT_SHA1 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA2 is 0b0000, this field must have the value 0b0000.

There is no rule to mandate FEAT_SHA256 if FEAT_SHA1 is implemented. Sure you can't have FEAT_SHA256 without FEAT_SHA1.

https://docs.kernel.org/arch/arm64/elf_hwcaps.html https://developer.apple.com/documentation/kernel/1387446-sysctlbyname/determining_instruction_set_characteristics

both kernel reports them separately.

[labrinea]

Sure you can't have FEAT_SHA256 without FEAT_SHA1

I came to the same conclusion when reading "If the value of ID_AA64ISAR0_EL1.SHA1 is 0b0000, this field must have the value 0b0000".

But this line "If the value of ID_AA64ISAR0_EL1.SHA2 is 0b0000, this field must have the value 0b0000" makes me think that you can't have FEAT_SHA1 without FEAT_SHA256.

https://docs.kernel.org/arch/arm64/elf_hwcaps.html https://developer.apple.com/documentation/kernel/1387446-sysctlbyname/determining_instruction_set_characteristics both kernel reports them separately.

The kernel also reports SM3 and SM4 separately but they are lumped in FMV. So as SHA512 and SHA3. Why is that?