ARM-software / acle

Arm C Language Extensions (ACLE)
Other
89 stars 58 forks source link

[FMV] Remove features which can be expressed as a combination of other features #353

Closed labrinea closed 2 weeks ago

labrinea commented 1 month ago

All of sve-bf16, sve-ebf16, and sve-i8mm are obsolete. This is already reflected on the second column of the FMV table (we have bf16, ebf16, and i8mm with the same Architecture name).

According to https://developer.arm.com/documentation/ddi0487/latest Arm Architecture Reference Manual for A-profile architecture:

D23.2.72 ID_AA64ISAR1_EL1, AArch64 Instruction Set Attribute Register 1

ID_AA64ISAR1_EL1.I8MM, bits [55:52]

When Advanced SIMD and SVE are both implemented, this field must return the same value as ID_AA64ZFR0_EL1.I8MM

ID_AA64ISAR1_EL1.BF16, bits [47:44]

When FEAT_SVE or FEAT_SME is implemented, this field must return the same value as ID_AA64ZFR0_EL1.BF16.

So one could write target_version("sve+bf16") or sme+bf16 instead.

There is a proposal to explicitely document FMV feature dependences in ACLE, so that the user won't have to write long feature strings on the attributes like sve+simd+i8mm (sve+i8mm should be enough).


name: Pull request about: Technical issues, document format problems, bugs in scripts or feature proposal.


Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution guidelines, in particular the section on submitting a proposal.

Please use the proposal label.

As for any pull request, please make sure to go through the below checklist.

Checklist: (mark with X those which apply)

labrinea commented 1 month ago

@tmatheson-arm

labrinea commented 1 month ago

Adding @andrewcarlotti and @DanielKristofKiss for visibility

andrewcarlotti commented 3 weeks ago

LGTM