search

ARM-software / armnn

Arm NN ML Software. The code here is a read-only mirror of https://review.mlplatform.org/admin/repos/ml/armnn
https://developer.arm.com/products/processors/machine-learning/arm-nn
MIT License
1.17k stars 310 forks source link

Update BuildGuideCrossCompilation.md #567

Closed adikachal closed 2 years ago

adikachal commented 3 years ago

we are already inside tensorflow directory see line 144 So should remove one "tensorflow" from the cp command

FrancisMurtagh-arm commented 3 years ago

Hi @adikachal

The cp command uses .. to go out of the tensorflow directory and then in again into the tensorflow/tensorflow/lite subdirectory which you can see is correct going by tensorflow git repo directory structure, although it is a bit confusing:

https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/schema

adikachal commented 3 years ago

@FrancisMurtagh-arm
Collaborator FrancisMurtagh-arm

This is the original syntax: mkdir tflite cd tflite cp ../tensorflow/tensorflow/lite/schema/schema.fbs .

so to the best I understand the ../ actually takes us out of tflite directory, isnt it?

FrancisMurtagh-arm commented 3 years ago

Hi @adikachal,

You're correct I didn't spot the tflite directory thanks.

We have a process for external contributions outlined here: https://github.com/ARM-software/armnn/tree/master#contributions

However, I will add a patch to Gerrit as it's such a small change.

Thanks, Francis.

FrancisMurtagh-arm commented 3 years ago

Hi @adikachal,

This is the patch to fix guide, it's done so as to match other guides/scripts.

https://review.mlplatform.org/c/ml/armnn/+/6077

Thanks, Francis.