search

ARM-software / armnn

Arm NN ML Software. The code here is a read-only mirror of https://review.mlplatform.org/admin/repos/ml/armnn
https://developer.arm.com/products/processors/machine-learning/arm-nn
MIT License
1.15k stars 307 forks source link

[Bug fix] ExpandDims Segmentation fault #595

Closed TheChosenStranger closed 1 year ago

TheChosenStranger commented 2 years ago

ExpandDims layer in TFLite caused segmentation fault while being parsed, this was fixed in the code.

Signed-off-by: Moustafa Ghareeb moustafa.ghareeb.hpg@gmail.com

TeresaARM commented 2 years ago

Hi @TheChosenStranger,

Thank you very much for your contribution to ArmNN, we would really love to review it and merge it.

However, instead of a pull request, we expect a commit in Gerrit. You should create a Gerrit review account at mlplatform.org and make your contribution there. You can use your GitHub credentials when creating your account.

The process for contributing to ArmNN is outlined in this Contributor Guide.

Please let us know if you find any issue.

Thank you very much. Kindest regards

TheChosenStranger commented 2 years ago

Hi @TeresaARM I tried several times to use gerrit to make the code change and there seems to be something wrong, I always the attached error. So I as asking if there is some sort of steps to do.

Regards, TheChosenStranger

image

TeresaARM commented 2 years ago

Hi @TheChosenStranger

I see your review in gerrit, but it only has a commit message: https://review.mlplatform.org/c/ml/armnn/+/7659

you can amend that review and add the code, so that we can run out tests over it.

Kindest Regards

TheChosenStranger commented 2 years ago

Hi @TeresaARM

The problem is that it doesn't accept my credentials for the push.

Regards

morgolock commented 1 year ago

Hi @TheChosenStranger please open an issue and we will help you to fix the problem with the credentials.