search

ARM-software / bbr-acs

Arm SystemReady : BBR Compliance Suite
Apache License 2.0
8 stars 28 forks source link

Fix SBBRRuntimeServices log info #61

Closed ownia closed 6 months ago

ownia commented 8 months ago

With this change, the full log information can be printed correctly (due to EFI_MAX_PRINT_BUFFER). eg: w/o patch

  Hdr.Signature             : 56524553544E5552
  Hdr.Revision              : 00020064
  Hdr.HeaderSize            : 00000088
  Hdr.CRC32                 : CA423A80
  Hdr.Reserved              : 00000000

  GetTime                   : EFF44AA4
  SetTime                   : EFF44930
  GetWakeupTime             : EFED7300
  SetWakeupTime             : EFED7300
  SetVirtualAddressMap      : EFF44C0C
  ConvertPointer            : EFED7328
  GetVariable               : EFF45648
  GetNextVariableName       : EFF4573C
  SetVariable               : EFF456C0
  GetNextHighMonotonicCount : EFED7300
  ResetSystem               : EFF44890
  QueryVariableInfo         : EFF45788
  QueryCapsuleCapabilities  : 

Returned Status Code: Success

with patch

  Hdr.Signature             : 56524553544E5552
  Hdr.Revision              : 00020064
  Hdr.HeaderSize            : 00000088
  Hdr.CRC32                 : CA423A80
  Hdr.Reserved              : 00000000

  GetTime                   : EFF44AA4
  SetTime                   : EFF44930
  GetWakeupTime             : EFED7300
  SetWakeupTime             : EFED7300
  SetVirtualAddressMap      : EFF44C0C
  ConvertPointer            : EFED7328
  GetVariable               : EFF45648
  GetNextVariableName       : EFF4573C
  SetVariable               : EFF456C0

  GetNextHighMonotonicCount : EFED7300
  ResetSystem               : EFF44890
  QueryVariableInfo         : EFF45788
  QueryCapsuleCapabilities  : EFF3C790
  UpdateCapsule             : EFF3C6A8

Returned Status Code: Success

Btw, I noticed that the EfiCompliantBBTestRequired_uefi.c has checked the Runtime Services, so shall we just remove this bbr case?

edhay commented 6 months ago

Hi @ownia , Thank you for the solution. We will let both the test exist for backward compatibility.