search

ARM-software / bsa-acs

Arm SystemReady : BSA Architecture Compliance Suite
Apache License 2.0
15 stars 41 forks source link

Test 806 autoskips: pal_pcie_get_legacy_irq_map unimplemented. Skipping test #208

Closed hrw closed 9 months ago

hrw commented 10 months ago

In my runs test 806 automatically skips:

 806 : Legacy int must be SPI & lvl-sensitive         START

       BDF - 0x400
       pal_pcie_get_legacy_irq_map unimplemented. Skipping test
       PCI_LI_01, PCI_LI_03
       Checkpoint --  2                           : Result:  SKIPPED
         END

Is this test some kind of work in progress?

If it skips due to lack of legacy interrupts in the system then maybe other message should be presented?

gowthamsiddarthd commented 9 months ago

Hi @hrw,

The API pal_pcie_get_legacy_irq_map() is platform-specific, and in order to execute tests related to legacy interrupts, it is essential for users to populate this API with the system's legacy IRQ map. This requirement is documented in the ReadMe for clarity, as detailed here: GitHub ReadMe.

To provide even more clarity on this matter, we have improved the print messages within the codebase, which have been incorporated into this pull request: GitHub Pull Request.

This enhancement aims to make it crystal clear for users that they need to take this specific action to ensure the correct functioning of legacy interrupt-related tests.

Regards, The ACS team

hrw commented 9 months ago

Thank you!