ARM-software / bsa-acs

Arm SystemReady : BSA Architecture Compliance Suite
Apache License 2.0
15 stars 41 forks source link

-rciep and -iep arguments are not handled #210

Closed hrw closed 10 months ago

hrw commented 10 months ago

BSA ACS has several arguments. But does not handle all of them:

Shell> fs0:Bsa.efi -h
[..]
-rciep  Enable running pcie tests for RCiEP
-iep    Enable running pcie tests for iEP
-sbsa   Enable sbsa requirements for bsa binary
-el1physkip Skips EL1 register checks

Shell> fs0:Bsa.efi -rciep
Shell command line parse error A
Unrecognized option -rciep passed

Shell> fs0:Bsa.efi -iep
Shell command line parse error A
Unrecognized option -iep passed

Maybe those options should be removed from help message if they are not supported?

hrw commented 10 months ago

They are not listed in Paramlist...


STATIC CONST SHELL_PARAM_ITEM ParamList[] = {
  {L"-v", TypeValue},    // -v    # Verbosity of the Prints. 1 shows all prints, 5 shows Errors
  {L"-f", TypeValue},    // -f    # Name of the log file to record the test results in.
  {L"-skip", TypeValue}, // -skip # test(s) to skip execution
  {L"-t", TypeValue},    // -t    # Test to be run
  {L"-m", TypeValue},    // -m    # Module to be run
  {L"-p2p", TypeFlag},   // -p2p  # Peer-to-Peer is supported
  {L"-cache", TypeFlag}, // -cache# PCIe address translation cache is supported
  {L"-timeout", TypeValue}, // -timeout # Set timeout multiple for wakeup tests
  {L"-help", TypeFlag},  // -help # help : info about commands
  {L"-h", TypeFlag},     // -h    # help : info about commands
  {L"-os", TypeFlag},    // -os   # Binary Flag to enable the execution of operating system tests.
  {L"-hyp", TypeFlag},   // -hyp  # Binary Flag to enable the execution of hypervisor tests.
  {L"-ps", TypeFlag},    // -ps   # Binary Flag to enable the execution of platform security tests.
  {L"-dtb", TypeValue},  // -dtb  # Binary Flag to enable dtb dump
  {L"-sbsa", TypeFlag},  // -sbsa # Enable sbsa requirements for bsa binary\n"
  {L"-mmio", TypeFlag}, // -mmio # Enable pal_mmio prints
  {L"-el1physkip", TypeFlag}, // -el1physkip # Skips EL1 register checks
  {NULL, TypeMax}
  };