ARM-software / bsa-acs

Arm SystemReady : BSA Architecture Compliance Suite
Apache License 2.0
15 stars 41 forks source link

PE test 12 bug introduced in #207 #213

Closed PhatFree closed 10 months ago

PhatFree commented 10 months ago

PR #207 introduced a bug in PE test 12. The code used to produce a boolean that was used compare watchpoints were >= 4, WRPs >2 (WRPs= Watchpoints -1). The new code adds 1 to that boolean, and is used to represent the number of watch points. this should fail on any system, as the only possible values are 2, and 1. https://github.com/ARM-software/bsa-acs/blob/24660c1cbc4d47b6086b56f0af34aac34546de6a/test_pool/pe/operating_system/test_os_c012.c#L35

It may also be better to say WRPs(+1) >=3/(4) rather than WRPs(+1) > 2/(3), for clarity?

https://github.com/ARM-software/bsa-acs/blob/24660c1cbc4d47b6086b56f0af34aac34546de6a/test_pool/pe/operating_system/test_os_c012.c#L37