For PCI test cases 804 and 830 but in general for all PCI test cases, I believe using MMIO for accessing config space or memory space is not correct. In these two test cases, PCI allocated memory space is being accessed using straight address deref. This will only work for systems that do not do any translation.
If you look at UEFI spec, PCI bus is supported by implementing Root Bridge I/O Protocol. This protocol provides the abstraction needed to access config and memory areas of PCI controllers and devices.
PCI test cases should use EFI_PCI_IO_PROTOCOL to access config and memory. Which in turn uses the host bridge driver for the hardware in question.
ndhillonm
commented
2 years ago
For PCI test cases 804 and 830 but in general for all PCI test cases, I believe using MMIO for accessing config space or memory space is not correct. In these two test cases, PCI allocated memory space is being accessed using straight address deref. This will only work for systems that do not do any translation.
If you look at UEFI spec, PCI bus is supported by implementing Root Bridge I/O Protocol. This protocol provides the abstraction needed to access config and memory areas of PCI controllers and devices.
PCI test cases should use EFI_PCI_IO_PROTOCOL to access config and memory. Which in turn uses the host bridge driver for the hardware in question.
Thanks,