ARM-software / bsa-acs

Arm SystemReady : BSA Architecture Compliance Suite
Apache License 2.0
14 stars 40 forks source link

The watchdog tests (504 and 702) need to be updated to use MMIO instead of non-UEFI-spec-defiend protocol #263

Closed sunnywang-arm closed 4 months ago

sunnywang-arm commented 4 months ago

bsa-acs is currently using gHardwareInterrupt2ProtocolGuid to run watchdog tests.

However, the gHardwareInterrupt2ProtocolGuid is not an architectural (UEFI or PI spec defined protocol). It is an "EDK2 implementation protocol". Meaning that independent UEFI applications like BSA/SBSA.efi should not depend on it. Otherwise, the behavior can be UNDEF on different implementations that are not using EDK2/TianoCore upstream code and we may run into exceptions below:

 504 : Wake from Watchdog WS0 Int                     START

       Setting Trigger type as 1  
        Unexpected exception occured
        FAR reported = 0xC10
        ESR reported = 0x96000006

702 : Check Watchdog WS0 interrupt                   START
       WS0 Interrupt id  67        
       Setting Trigger type as 1  
        Unexpected exception occured
        FAR reported = 0xC10
        ESR reported = 0x96000006