search

ARM-software / bsa-acs

Arm SystemReady : BSA Architecture Compliance Suite
Apache License 2.0
14 stars 40 forks source link

PE test 1 doesn't check last few PE registers in reg_list[] #308

Open sunnywang-arm opened 1 month ago

sunnywang-arm commented 1 month ago

The value of NUM_OF_REGISTERS should be updated to match the number of registers in reg_list []. There are more than 32 registers in reg_list[]. https://github.com/ARM-software/bsa-acs/blob/8d2382ad2be86ee2598dc69703e11c9315c3cf2b/test_pool/pe/operating_system/test_os_c001.c#L25

hrw commented 1 month ago

Also reg_list is very incomplete compared to armarm K.a version.

magicse7en commented 2 weeks ago

some register reads are commented out, which should also be updated. https://github.com/ARM-software/bsa-acs/blob/main/val/common/src/AArch64/PeRegSysSupport.S#L394C9-L394C23

sunnywang-arm commented 2 weeks ago

Thanks for the feedback, @hrw and @magicse7en. Agree with your comments. I created another task to update the list. https://github.com/ARM-software/bsa-acs/issues/318