search

ARM-software / bsa-acs

Arm SystemReady : BSA Architecture Compliance Suite
Apache License 2.0
16 stars 42 forks source link

Test 601 improperly failing USB 1.1 controllers #42

Closed PhatFree closed 2 years ago

PhatFree commented 2 years ago

According to RB_PER_01 & RB_PER_02 of BSA, If the system has a USB2.0/USB3.0 host controller, it needs to be EHCI/XHCI complaint.

But test 601 is just testing all USB controllers to see if they're XHCI or EHCI complaint, improperly failing USB 1.1 controllers that are not complaint with either.

https://github.com/ARM-software/bsa-acs/blob/79986b026a923550b74783e8376b7126bb2c63d4/test_pool/peripherals/operating_system/test_os_d001.c#L47

samerhaj commented 2 years ago

In other words, the BSA Spec does not forbid UHCI (USB 1.1) host controllers form existing in a compliant system. All what the spec is saying is that If USB 2.0 or USB 3.0 host controllers are present, they must be compliant to the EHCI or XHCI specifications.

The test is not really checking the compliance of these rules. As it is written, every failure to this test is going to be a false positive, an the test cannot really detect non-compliance of these BSA rules.

chetan-rathore commented 2 years ago

Thanks @PhatFree and @samerhaj for your inputs.

We are checking the issue on our side.

Thanks, ACS team

chetan-rathore commented 2 years ago

Hi @PhatFree,

The changes are merged.

Thanks, ACS team