ARM-software / devlib

Library for interaction with and instrumentation of remote devices.
Apache License 2.0
47 stars 78 forks source link

Cleanup transfer manager #619

Closed douglas-raillard-arm closed 1 year ago

douglas-raillard-arm commented 1 year ago

Cleanup and simplify transfer manager infrastructure to make it more reliable.

WARNING: Not tested on SSH connection yet. Tested on android along https://github.com/ARM-software/devlib/pull/618

mrkajetanp commented 1 year ago

With the above changes the PR makes the PerfettoCollector work fine without specifying an explicit pull timeout so looks like it works :)

douglas-raillard-arm commented 1 year ago

@mrkajetanp I updated the PR with your review, thanks for testing it

mrkajetanp commented 1 year ago

We should be good to go then! I'll update the Collector PR to drop the timeout in that case

douglas-raillard-arm commented 1 year ago

PR updated with both typos fixed

douglas-raillard-arm commented 1 year ago

PR updated:

Thanks a lot for the testing

douglas-raillard-arm commented 1 year ago

PR updated with:

douglas-raillard-arm commented 1 year ago

PR updated with s/mgr/manager, and rebased on master (there was a conflict so we might want to give it a last spin before merging)