ARM-software / devlib

Library for interaction with and instrumentation of remote devices.
Apache License 2.0
47 stars 78 forks source link

Fix kick off #624

Closed douglas-raillard-arm closed 1 year ago

douglas-raillard-arm commented 1 year ago

Following @mrkajetanp tests, I updated the PR to use Target.background() instead of relying on nohup and &. The & unfortunately only makes the command a background job in the shell, but adb shell blocks until all background jobs are finished before exiting, making it useless.

Instead, using Target.background() provides the expected behavior. The main change is that background commands are canceled on target disconnect for some connection classes (but not all it seems, we might want to align behaviors there)

douglas-raillard-arm commented 1 year ago

So we should probably:

EDIT: the 2) is implemented there but needs an adjustment before being ready: https://github.com/ARM-software/devlib/pull/626

mrkajetanp commented 1 year ago

I can confirm that with the updated PR the instrument finally works as expected so simply getting rid of kick_off this way is probably a good idea.