search

ARM-software / devlib

Library for interaction with and instrumentation of remote devices.
Apache License 2.0
47 stars 78 forks source link

utils.rendering: Fix activity matching #638

Closed mrkajetanp closed 1 year ago

mrkajetanp commented 1 year ago

Change the SurfaceFlingerFrameCollector to match activities by prefix instead of looking for an exact match. This will allow to account for activities with variable suffixes. Raise an error if more than one activity matches the provided view.

Suggested-by: Andriani Mappoura andriani.mappoura@arm.com

mrkajetanp commented 1 year ago

Note: The current behaviour is to silently fail if the view doesn't match any of the activities found by SurfaceFlinger. I left that unchanged but I think it probably makes sense to add another check and throw a warning if the list is empty so that the user at least knows where the problem is coming from. I can update the PR if that's desirable to have.

mrkajetanp commented 1 year ago

All right I updated the PR, should be ready now :)