ARM-software / devlib

Library for interaction with and instrumentation of remote devices.
Apache License 2.0
45 stars 77 forks source link

ftrace: Do not read-verify buffer_size_kb value #650

Closed cloehle closed 10 months ago

cloehle commented 10 months ago

The sysfs documentation mentions that the value written to buffer_size_kb ftrace field may be rounded up. So skip the verify loop on this field.

The case we are worried about, a requested buffer size that the target cannot fulfill is caught anyway, as the sysfs write returns with an error that is caught.

douglas-raillard-arm commented 10 months ago

@marcbonnici note that we started encountering this on recent mainline kernels, so we cannot use the FtraceCollector on them at the moment without that fix

cloehle commented 10 months ago

Thanks! FYI the change making that necessary was commit 6d98a0f2ac3c ("tracing: Set actual size after ring buffer resize")