tools/android: Address review comments on PR#668 - Githubissues

ARM-software / devlib

Library for interaction with and instrumentation of remote devices.

Apache License 2.0

47 stars 78 forks source link

tools/android: Address review comments on PR#668 #678

Closed metin-arm closed 4 months ago

metin-arm commented 6 months ago

Note: Only https://github.com/ARM-software/devlib/commit/e56c887091ec140e8d5baf6e77f14c634358cc48 needs to be reviewed.

PR#668: https://github.com/ARM-software/devlib/pull/668

Fix mixed tab-space white-spacing issues
s/CMDLINE_VERSION/ANDROID_CMDLINE_VERSION/ to be more precise
s/set_host_arch/get_android_sdk_host_arch/ because the global variable for Android host architecture is removed now

This PR should be merged after https://github.com/ARM-software/devlib/pull/677

douglas-raillard-arm commented 4 months ago

Still LGTM