search

ARM-software / gator

Sources for Arm Streamline's gator daemon, part of Arm Mobile Studio suite of performance analysis tools
https://www.arm.com/products/development-tools/graphics/arm-mobile-studio
133 stars 70 forks source link

CMake failed to find MXML #37

Closed clementperon closed 1 year ago

clementperon commented 1 year ago

Hi,

I'm trying to build gator 8.1.0 but Cmake complain that it can't find MXML

| CMake Error at CMakeLists.txt:67 (FIND_PACKAGE):
|   Could not find a package configuration file provided by "mxml" with any of
|   the following names:
| 
|     mxmlConfig.cmake
|     mxml-config.cmake

https://github.com/ARM-software/gator/blob/c1e117edddbdd7f9a23528bdf0355e5249abf52c/daemon/CMakeLists.txt#L89

Looking at the mxml library, but it looks like it doesn't support CMake build at the moment :

https://github.com/michaelrsweet/mxml See: https://github.com/michaelrsweet/mxml/pull/281

bengaineyarm commented 1 year ago

Hi @clementperon thanks for this. I guess you are using system provided dependencies, rather than using vcpkg?

Presumably, if you are using your own dependency manager, you can provide mxml with iirc pkg-config configuration, or something like that... I expect we just need an

if (VCPKG) do x else do y

construct in the cmake to handle this case.

bengaineyarm commented 1 year ago

@clementperon Are you able to let me know if this works for you: https://github.com/ARM-software/gator/pull/39

bengaineyarm commented 1 year ago

Resolved by https://github.com/ARM-software/gator/pull/39